dan
/
tor-android
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Don't strip binaries when doing a debug build. 

This patch allows the developer to build the external binaries with
DEBUG=1 which ensures that the final binaries are not stripped from any
debug symbols.

This makes the binaries useful together with Google's simpleperf
profiler for Android.
This commit is contained in:
Alexander Færøy 2017-10-29 22:56:52 -04:00
parent 87edea9ce6
commit d591cdb0df
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
external/Makefile vendored
View File

@ -11,6 +11,11 @@ export ac_cv_func_setpgrp_void=yes
EXTERNAL_ROOT := $(shell pwd) EXTERNAL_ROOT := $(shell pwd)
DEBUG ?= 0
# No-op command.
NOOP = true
# Android now has 64-bit and 32-bit versions of the NDK for GNU/Linux. We # Android now has 64-bit and 32-bit versions of the NDK for GNU/Linux. We
# assume that the build platform uses the appropriate version, otherwise the # assume that the build platform uses the appropriate version, otherwise the
# user building this will have to manually set NDK_PROCESSOR or NDK_TOOLCHAIN. # user building this will have to manually set NDK_PROCESSOR or NDK_TOOLCHAIN.
@ -71,8 +76,12 @@ CPP := $(NDK_TOOLCHAIN_BASE)/bin/$(HOST)-cpp --sysroot=$(NDK_SYSROOT)
LD := $(NDK_TOOLCHAIN_BASE)/bin/$(HOST)-ld LD := $(NDK_TOOLCHAIN_BASE)/bin/$(HOST)-ld
AR := $(NDK_TOOLCHAIN_BASE)/bin/$(HOST)-ar AR := $(NDK_TOOLCHAIN_BASE)/bin/$(HOST)-ar
RANLIB := $(NDK_TOOLCHAIN_BASE)/bin/$(HOST)-ranlib RANLIB := $(NDK_TOOLCHAIN_BASE)/bin/$(HOST)-ranlib
STRIP := $(NDK_TOOLCHAIN_BASE)/bin/$(HOST)-strip \
--strip-unneeded -R .note -R .comment --strip-debug ifeq ($(DEBUG), 1)
STRIP := $(NOOP)
else
STRIP := $(NDK_TOOLCHAIN_BASE)/bin/$(HOST)-strip --strip-unneeded -R .note -R .comment --strip-debug
endif
CFLAGS = -DANDROID $(TARGET_CFLAGS) $(PIEFLAGS) CFLAGS = -DANDROID $(TARGET_CFLAGS) $(PIEFLAGS)