From d28db417827c601eddaf6be9f01326c68b9c3e03 Mon Sep 17 00:00:00 2001
From: arrase <arrase@gmail.com>
Date: Thu, 24 Nov 2016 02:56:11 +0100
Subject: [PATCH] big refactor

---
 app/src/main/AndroidManifest.xml                   | 10 +++++-----
 .../org/torproject/android/OrbotMainActivity.java  |  6 +++---
 .../HiddenServicesActivity.java                    | 14 +++++++-------
 .../adapters/BackupAdapter.java                    |  2 +-
 .../adapters/OnionListAdapter.java                 |  4 ++--
 .../hiddenservices}/backup/BackupUtils.java        |  4 ++--
 .../{ => ui/hiddenservices}/backup/ZipIt.java      |  2 +-
 .../database/HSDatabase.java                       |  2 +-
 .../dialogs/HSActionsDialog.java                   | 14 ++++----------
 .../dialogs/HSDataDialog.java                      |  4 ++--
 .../dialogs/SelectBackupDialog.java                |  6 +++---
 .../providers/HSContentProvider.java               |  6 +++---
 .../hiddenservices}/storage/AppDataProvider.java   |  2 +-
 .../hiddenservices}/storage/ExternalStorage.java   |  2 +-
 .../hiddenservices}/storage/PermissionManager.java |  2 +-
 app/src/main/res/layout/layout_hs_list_view.xml    |  2 +-
 .../main/res/layout/layout_hs_list_view_main.xml   |  2 +-
 .../org/torproject/android/service/TorService.java |  2 +-
 18 files changed, 40 insertions(+), 46 deletions(-)
 rename app/src/main/java/org/torproject/android/ui/{hs => hiddenservices}/HiddenServicesActivity.java (89%)
 rename app/src/main/java/org/torproject/android/ui/{hs => hiddenservices}/adapters/BackupAdapter.java (95%)
 rename app/src/main/java/org/torproject/android/ui/{hs => hiddenservices}/adapters/OnionListAdapter.java (91%)
 rename app/src/main/java/org/torproject/android/{ => ui/hiddenservices}/backup/BackupUtils.java (93%)
 rename app/src/main/java/org/torproject/android/{ => ui/hiddenservices}/backup/ZipIt.java (97%)
 rename app/src/main/java/org/torproject/android/ui/{hs => hiddenservices}/database/HSDatabase.java (94%)
 rename app/src/main/java/org/torproject/android/ui/{hs => hiddenservices}/dialogs/HSActionsDialog.java (90%)
 rename app/src/main/java/org/torproject/android/ui/{hs => hiddenservices}/dialogs/HSDataDialog.java (95%)
 rename app/src/main/java/org/torproject/android/ui/{hs => hiddenservices}/dialogs/SelectBackupDialog.java (92%)
 rename app/src/main/java/org/torproject/android/ui/{hs => hiddenservices}/providers/HSContentProvider.java (96%)
 rename app/src/main/java/org/torproject/android/{ => ui/hiddenservices}/storage/AppDataProvider.java (95%)
 rename app/src/main/java/org/torproject/android/{ => ui/hiddenservices}/storage/ExternalStorage.java (94%)
 rename app/src/main/java/org/torproject/android/{ => ui/hiddenservices}/storage/PermissionManager.java (97%)

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index c0990769..b7a5e879 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -137,7 +137,7 @@
         </receiver>
 
         <activity
-            android:name=".ui.hs.HiddenServicesActivity"
+            android:name=".ui.hiddenservices.HiddenServicesActivity"
             android:label="@string/title_activity_hidden_services"
             android:theme="@style/DefaultTheme" >
             <meta-data
@@ -146,13 +146,13 @@
         </activity>
 
         <provider
-            android:name=".ui.hs.providers.HSContentProvider"
+            android:name=".ui.hiddenservices.providers.HSContentProvider"
             android:exported="false"
-            android:authorities="org.torproject.android.ui.hs.providers" />
+            android:authorities="org.torproject.android.ui.hiddenservices.providers" />
 
         <provider
-            android:name="org.torproject.android.storage.AppDataProvider"
-            android:authorities="org.torproject.android.storage"
+            android:name=".ui.hiddenservices.storage.AppDataProvider"
+            android:authorities="org.torproject.android.ui.hiddenservices.storage"
             android:exported="false"
             android:grantUriPermissions="true">
             <meta-data
diff --git a/app/src/main/java/org/torproject/android/OrbotMainActivity.java b/app/src/main/java/org/torproject/android/OrbotMainActivity.java
index 1ea9b6e9..9a5bfb5f 100644
--- a/app/src/main/java/org/torproject/android/OrbotMainActivity.java
+++ b/app/src/main/java/org/torproject/android/OrbotMainActivity.java
@@ -23,13 +23,13 @@ import org.torproject.android.service.TorServiceConstants;
 import org.torproject.android.service.util.TorServiceUtils;
 import org.torproject.android.settings.SettingsPreferences;
 import org.torproject.android.ui.AppManager;
-import org.torproject.android.ui.hs.HiddenServicesActivity;
+import org.torproject.android.ui.hiddenservices.HiddenServicesActivity;
 import org.torproject.android.ui.ImageProgressView;
 import org.torproject.android.ui.PromoAppsActivity;
 import org.torproject.android.ui.Rotate3dAnimation;
-import org.torproject.android.ui.hs.providers.HSContentProvider;
+import org.torproject.android.ui.hiddenservices.providers.HSContentProvider;
 import org.torproject.android.vpn.VPNEnableActivity;
-import org.torproject.android.backup.BackupUtils;
+import org.torproject.android.ui.hiddenservices.backup.BackupUtils;
 
 import android.annotation.SuppressLint;
 import android.app.ActivityManager;
diff --git a/app/src/main/java/org/torproject/android/ui/hs/HiddenServicesActivity.java b/app/src/main/java/org/torproject/android/ui/hiddenservices/HiddenServicesActivity.java
similarity index 89%
rename from app/src/main/java/org/torproject/android/ui/hs/HiddenServicesActivity.java
rename to app/src/main/java/org/torproject/android/ui/hiddenservices/HiddenServicesActivity.java
index 4474668c..119b13ad 100644
--- a/app/src/main/java/org/torproject/android/ui/hs/HiddenServicesActivity.java
+++ b/app/src/main/java/org/torproject/android/ui/hiddenservices/HiddenServicesActivity.java
@@ -1,4 +1,4 @@
-package org.torproject.android.ui.hs;
+package org.torproject.android.ui.hiddenservices;
 
 
 import android.content.ContentResolver;
@@ -16,12 +16,12 @@ import android.widget.ListView;
 import android.widget.TextView;
 
 import org.torproject.android.R;
-import org.torproject.android.storage.PermissionManager;
-import org.torproject.android.ui.hs.adapters.OnionListAdapter;
-import org.torproject.android.ui.hs.dialogs.HSActionsDialog;
-import org.torproject.android.ui.hs.dialogs.HSDataDialog;
-import org.torproject.android.ui.hs.dialogs.SelectBackupDialog;
-import org.torproject.android.ui.hs.providers.HSContentProvider;
+import org.torproject.android.ui.hiddenservices.storage.PermissionManager;
+import org.torproject.android.ui.hiddenservices.adapters.OnionListAdapter;
+import org.torproject.android.ui.hiddenservices.dialogs.HSActionsDialog;
+import org.torproject.android.ui.hiddenservices.dialogs.HSDataDialog;
+import org.torproject.android.ui.hiddenservices.dialogs.SelectBackupDialog;
+import org.torproject.android.ui.hiddenservices.providers.HSContentProvider;
 
 public class HiddenServicesActivity extends AppCompatActivity {
     private ContentResolver mCR;
diff --git a/app/src/main/java/org/torproject/android/ui/hs/adapters/BackupAdapter.java b/app/src/main/java/org/torproject/android/ui/hiddenservices/adapters/BackupAdapter.java
similarity index 95%
rename from app/src/main/java/org/torproject/android/ui/hs/adapters/BackupAdapter.java
rename to app/src/main/java/org/torproject/android/ui/hiddenservices/adapters/BackupAdapter.java
index bcc7a5a4..196023b3 100644
--- a/app/src/main/java/org/torproject/android/ui/hs/adapters/BackupAdapter.java
+++ b/app/src/main/java/org/torproject/android/ui/hiddenservices/adapters/BackupAdapter.java
@@ -1,4 +1,4 @@
-package org.torproject.android.ui.hs.adapters;
+package org.torproject.android.ui.hiddenservices.adapters;
 
 import android.content.Context;
 import android.view.LayoutInflater;
diff --git a/app/src/main/java/org/torproject/android/ui/hs/adapters/OnionListAdapter.java b/app/src/main/java/org/torproject/android/ui/hiddenservices/adapters/OnionListAdapter.java
similarity index 91%
rename from app/src/main/java/org/torproject/android/ui/hs/adapters/OnionListAdapter.java
rename to app/src/main/java/org/torproject/android/ui/hiddenservices/adapters/OnionListAdapter.java
index 0ae10cb7..1edbef22 100644
--- a/app/src/main/java/org/torproject/android/ui/hs/adapters/OnionListAdapter.java
+++ b/app/src/main/java/org/torproject/android/ui/hiddenservices/adapters/OnionListAdapter.java
@@ -1,4 +1,4 @@
-package org.torproject.android.ui.hs.adapters;
+package org.torproject.android.ui.hiddenservices.adapters;
 
 import android.content.Context;
 import android.database.Cursor;
@@ -9,7 +9,7 @@ import android.view.ViewGroup;
 import android.widget.TextView;
 
 import org.torproject.android.R;
-import org.torproject.android.ui.hs.providers.HSContentProvider;
+import org.torproject.android.ui.hiddenservices.providers.HSContentProvider;
 
 public class OnionListAdapter extends CursorAdapter {
     private LayoutInflater cursorInflater;
diff --git a/app/src/main/java/org/torproject/android/backup/BackupUtils.java b/app/src/main/java/org/torproject/android/ui/hiddenservices/backup/BackupUtils.java
similarity index 93%
rename from app/src/main/java/org/torproject/android/backup/BackupUtils.java
rename to app/src/main/java/org/torproject/android/ui/hiddenservices/backup/BackupUtils.java
index 57d8c8d3..c60beb91 100644
--- a/app/src/main/java/org/torproject/android/backup/BackupUtils.java
+++ b/app/src/main/java/org/torproject/android/ui/hiddenservices/backup/BackupUtils.java
@@ -1,4 +1,4 @@
-package org.torproject.android.backup;
+package org.torproject.android.ui.hiddenservices.backup;
 
 import android.app.Application;
 import android.content.Context;
@@ -6,7 +6,7 @@ import android.widget.Toast;
 
 import org.torproject.android.service.R;
 import org.torproject.android.service.TorServiceConstants;
-import org.torproject.android.storage.ExternalStorage;
+import org.torproject.android.ui.hiddenservices.storage.ExternalStorage;
 
 import java.io.File;
 import java.io.IOException;
diff --git a/app/src/main/java/org/torproject/android/backup/ZipIt.java b/app/src/main/java/org/torproject/android/ui/hiddenservices/backup/ZipIt.java
similarity index 97%
rename from app/src/main/java/org/torproject/android/backup/ZipIt.java
rename to app/src/main/java/org/torproject/android/ui/hiddenservices/backup/ZipIt.java
index bde29f09..42e0bf9b 100644
--- a/app/src/main/java/org/torproject/android/backup/ZipIt.java
+++ b/app/src/main/java/org/torproject/android/ui/hiddenservices/backup/ZipIt.java
@@ -1,4 +1,4 @@
-package org.torproject.android.backup;
+package org.torproject.android.ui.hiddenservices.backup;
 
 
 import java.io.BufferedInputStream;
diff --git a/app/src/main/java/org/torproject/android/ui/hs/database/HSDatabase.java b/app/src/main/java/org/torproject/android/ui/hiddenservices/database/HSDatabase.java
similarity index 94%
rename from app/src/main/java/org/torproject/android/ui/hs/database/HSDatabase.java
rename to app/src/main/java/org/torproject/android/ui/hiddenservices/database/HSDatabase.java
index 07e2ca29..8f1123fa 100644
--- a/app/src/main/java/org/torproject/android/ui/hs/database/HSDatabase.java
+++ b/app/src/main/java/org/torproject/android/ui/hiddenservices/database/HSDatabase.java
@@ -1,4 +1,4 @@
-package org.torproject.android.ui.hs.database;
+package org.torproject.android.ui.hiddenservices.database;
 
 
 import android.content.Context;
diff --git a/app/src/main/java/org/torproject/android/ui/hs/dialogs/HSActionsDialog.java b/app/src/main/java/org/torproject/android/ui/hiddenservices/dialogs/HSActionsDialog.java
similarity index 90%
rename from app/src/main/java/org/torproject/android/ui/hs/dialogs/HSActionsDialog.java
rename to app/src/main/java/org/torproject/android/ui/hiddenservices/dialogs/HSActionsDialog.java
index d5603b71..103f87ba 100644
--- a/app/src/main/java/org/torproject/android/ui/hs/dialogs/HSActionsDialog.java
+++ b/app/src/main/java/org/torproject/android/ui/hiddenservices/dialogs/HSActionsDialog.java
@@ -1,20 +1,14 @@
-package org.torproject.android.ui.hs.dialogs;
+package org.torproject.android.ui.hiddenservices.dialogs;
 
 
-import android.Manifest;
-import android.annotation.SuppressLint;
 import android.app.Dialog;
 import android.content.ClipData;
 import android.content.ClipboardManager;
 import android.content.Context;
 import android.content.Intent;
-import android.content.pm.PackageManager;
 import android.net.Uri;
-import android.os.Build;
 import android.os.Bundle;
 import android.support.annotation.NonNull;
-import android.support.design.widget.Snackbar;
-import android.support.v4.app.ActivityCompat;
 import android.support.v4.app.DialogFragment;
 import android.support.v7.app.AlertDialog;
 import android.view.View;
@@ -22,9 +16,9 @@ import android.widget.Button;
 import android.widget.Toast;
 
 import org.torproject.android.R;
-import org.torproject.android.backup.BackupUtils;
-import org.torproject.android.storage.PermissionManager;
-import org.torproject.android.ui.hs.providers.HSContentProvider;
+import org.torproject.android.ui.hiddenservices.backup.BackupUtils;
+import org.torproject.android.ui.hiddenservices.storage.PermissionManager;
+import org.torproject.android.ui.hiddenservices.providers.HSContentProvider;
 
 public class HSActionsDialog extends DialogFragment {
     public final int PERMISSIONS_REQUEST_WRITE_EXTERNAL_STORAGE = 1;
diff --git a/app/src/main/java/org/torproject/android/ui/hs/dialogs/HSDataDialog.java b/app/src/main/java/org/torproject/android/ui/hiddenservices/dialogs/HSDataDialog.java
similarity index 95%
rename from app/src/main/java/org/torproject/android/ui/hs/dialogs/HSDataDialog.java
rename to app/src/main/java/org/torproject/android/ui/hiddenservices/dialogs/HSDataDialog.java
index 922b7f05..0b04135b 100644
--- a/app/src/main/java/org/torproject/android/ui/hs/dialogs/HSDataDialog.java
+++ b/app/src/main/java/org/torproject/android/ui/hiddenservices/dialogs/HSDataDialog.java
@@ -1,4 +1,4 @@
-package org.torproject.android.ui.hs.dialogs;
+package org.torproject.android.ui.hiddenservices.dialogs;
 
 
 import android.app.Dialog;
@@ -14,7 +14,7 @@ import android.widget.EditText;
 import android.widget.Toast;
 
 import org.torproject.android.R;
-import org.torproject.android.ui.hs.providers.HSContentProvider;
+import org.torproject.android.ui.hiddenservices.providers.HSContentProvider;
 
 public class HSDataDialog extends DialogFragment {
 
diff --git a/app/src/main/java/org/torproject/android/ui/hs/dialogs/SelectBackupDialog.java b/app/src/main/java/org/torproject/android/ui/hiddenservices/dialogs/SelectBackupDialog.java
similarity index 92%
rename from app/src/main/java/org/torproject/android/ui/hs/dialogs/SelectBackupDialog.java
rename to app/src/main/java/org/torproject/android/ui/hiddenservices/dialogs/SelectBackupDialog.java
index 37c722bf..ce2c7172 100644
--- a/app/src/main/java/org/torproject/android/ui/hs/dialogs/SelectBackupDialog.java
+++ b/app/src/main/java/org/torproject/android/ui/hiddenservices/dialogs/SelectBackupDialog.java
@@ -1,4 +1,4 @@
-package org.torproject.android.ui.hs.dialogs;
+package org.torproject.android.ui.hiddenservices.dialogs;
 
 import android.app.Dialog;
 import android.content.DialogInterface;
@@ -11,8 +11,8 @@ import android.widget.AdapterView;
 import android.widget.ListView;
 
 import org.torproject.android.R;
-import org.torproject.android.storage.ExternalStorage;
-import org.torproject.android.ui.hs.adapters.BackupAdapter;
+import org.torproject.android.ui.hiddenservices.storage.ExternalStorage;
+import org.torproject.android.ui.hiddenservices.adapters.BackupAdapter;
 
 import java.io.File;
 import java.io.FilenameFilter;
diff --git a/app/src/main/java/org/torproject/android/ui/hs/providers/HSContentProvider.java b/app/src/main/java/org/torproject/android/ui/hiddenservices/providers/HSContentProvider.java
similarity index 96%
rename from app/src/main/java/org/torproject/android/ui/hs/providers/HSContentProvider.java
rename to app/src/main/java/org/torproject/android/ui/hiddenservices/providers/HSContentProvider.java
index f222b854..856c6853 100644
--- a/app/src/main/java/org/torproject/android/ui/hs/providers/HSContentProvider.java
+++ b/app/src/main/java/org/torproject/android/ui/hiddenservices/providers/HSContentProvider.java
@@ -1,4 +1,4 @@
-package org.torproject.android.ui.hs.providers;
+package org.torproject.android.ui.hiddenservices.providers;
 
 import android.content.ContentProvider;
 import android.content.ContentUris;
@@ -12,11 +12,11 @@ import android.provider.BaseColumns;
 import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
 
-import org.torproject.android.ui.hs.database.HSDatabase;
+import org.torproject.android.ui.hiddenservices.database.HSDatabase;
 
 
 public class HSContentProvider extends ContentProvider {
-    private static final String AUTH = "org.torproject.android.ui.hs.providers";
+    private static final String AUTH = "org.torproject.android.ui.hiddenservices.providers";
     public static final Uri CONTENT_URI =
             Uri.parse("content://" + AUTH + "/hs");
     //UriMatcher
diff --git a/app/src/main/java/org/torproject/android/storage/AppDataProvider.java b/app/src/main/java/org/torproject/android/ui/hiddenservices/storage/AppDataProvider.java
similarity index 95%
rename from app/src/main/java/org/torproject/android/storage/AppDataProvider.java
rename to app/src/main/java/org/torproject/android/ui/hiddenservices/storage/AppDataProvider.java
index c04a2936..6e555694 100644
--- a/app/src/main/java/org/torproject/android/storage/AppDataProvider.java
+++ b/app/src/main/java/org/torproject/android/ui/hiddenservices/storage/AppDataProvider.java
@@ -1,4 +1,4 @@
-package org.torproject.android.storage;
+package org.torproject.android.ui.hiddenservices.storage;
 
 
 import android.app.Application;
diff --git a/app/src/main/java/org/torproject/android/storage/ExternalStorage.java b/app/src/main/java/org/torproject/android/ui/hiddenservices/storage/ExternalStorage.java
similarity index 94%
rename from app/src/main/java/org/torproject/android/storage/ExternalStorage.java
rename to app/src/main/java/org/torproject/android/ui/hiddenservices/storage/ExternalStorage.java
index bea196e0..cda3f8ce 100644
--- a/app/src/main/java/org/torproject/android/storage/ExternalStorage.java
+++ b/app/src/main/java/org/torproject/android/ui/hiddenservices/storage/ExternalStorage.java
@@ -1,4 +1,4 @@
-package org.torproject.android.storage;
+package org.torproject.android.ui.hiddenservices.storage;
 
 import android.os.Environment;
 
diff --git a/app/src/main/java/org/torproject/android/storage/PermissionManager.java b/app/src/main/java/org/torproject/android/ui/hiddenservices/storage/PermissionManager.java
similarity index 97%
rename from app/src/main/java/org/torproject/android/storage/PermissionManager.java
rename to app/src/main/java/org/torproject/android/ui/hiddenservices/storage/PermissionManager.java
index 128db8ef..80706c5d 100644
--- a/app/src/main/java/org/torproject/android/storage/PermissionManager.java
+++ b/app/src/main/java/org/torproject/android/ui/hiddenservices/storage/PermissionManager.java
@@ -1,4 +1,4 @@
-package org.torproject.android.storage;
+package org.torproject.android.ui.hiddenservices.storage;
 
 
 import android.Manifest;
diff --git a/app/src/main/res/layout/layout_hs_list_view.xml b/app/src/main/res/layout/layout_hs_list_view.xml
index c47a3929..3e7b32fc 100644
--- a/app/src/main/res/layout/layout_hs_list_view.xml
+++ b/app/src/main/res/layout/layout_hs_list_view.xml
@@ -5,7 +5,7 @@
     android:layout_width="match_parent"
     android:layout_height="match_parent"
     android:fitsSystemWindows="true"
-    tools:context="org.torproject.android.ui.hs.HiddenServicesActivity">
+    tools:context="org.torproject.android.ui.hiddenservices.HiddenServicesActivity">
 
     <android.support.design.widget.AppBarLayout
         android:layout_width="match_parent"
diff --git a/app/src/main/res/layout/layout_hs_list_view_main.xml b/app/src/main/res/layout/layout_hs_list_view_main.xml
index bb1c94c9..284a01c7 100644
--- a/app/src/main/res/layout/layout_hs_list_view_main.xml
+++ b/app/src/main/res/layout/layout_hs_list_view_main.xml
@@ -10,7 +10,7 @@
     android:paddingRight="@dimen/activity_horizontal_margin"
     android:paddingTop="@dimen/activity_vertical_margin"
     app:layout_behavior="@string/appbar_scrolling_view_behavior"
-    tools:context="org.torproject.android.ui.hs.HiddenServicesActivity"
+    tools:context="org.torproject.android.ui.hiddenservices.HiddenServicesActivity"
     tools:showIn="@layout/layout_hs_list_view">
 
     <ListView
diff --git a/orbotservice/src/main/java/org/torproject/android/service/TorService.java b/orbotservice/src/main/java/org/torproject/android/service/TorService.java
index f8ed3b34..6d124246 100644
--- a/orbotservice/src/main/java/org/torproject/android/service/TorService.java
+++ b/orbotservice/src/main/java/org/torproject/android/service/TorService.java
@@ -132,7 +132,7 @@ public class TorService extends Service implements TorServiceConstants, OrbotCon
     private Shell mShellPolipo;
 
 
-    private static final Uri CONTENT_URI = Uri.parse("content://org.torproject.android.ui.hs.providers/hs");
+    private static final Uri CONTENT_URI = Uri.parse("content://org.torproject.android.ui.hiddenservices.providers/hs");
 
     public static final class HiddenService implements BaseColumns {
         public static final String NAME = "name";