From bb0b7e8fe29b80f8dcd4a83cb183a5d6fbaf3edc Mon Sep 17 00:00:00 2001 From: Nathan Freitas Date: Tue, 24 Jun 2014 10:06:26 -0400 Subject: [PATCH] unbind the service when the activity is destroyed we don't want leaky services --- src/org/torproject/android/Orbot.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/org/torproject/android/Orbot.java b/src/org/torproject/android/Orbot.java index f7e0f95e..5e6a9550 100644 --- a/src/org/torproject/android/Orbot.java +++ b/src/org/torproject/android/Orbot.java @@ -111,11 +111,10 @@ public class Orbot extends ActionBarActivity implements TorConstants, OnLongClic torService = new Intent(this, TorService.class); startService(torService); - bindService(torService, mConnection, Context.BIND_AUTO_CREATE); - + } private void doLayout () @@ -1261,7 +1260,7 @@ public class Orbot extends ActionBarActivity implements TorConstants, OnLongClic protected void onDestroy() { super.onDestroy(); - //unbindService(); + unbindService(mConnection); } public class DataCount {