From b322e530da659d714dc28679b158c3ed8fee8d7b Mon Sep 17 00:00:00 2001 From: n8fr8 Date: Mon, 16 Oct 2017 23:36:14 -0400 Subject: [PATCH] make sure receiver unregisters when destroyed --- .../torproject/android/service/TorService.java | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/orbotservice/src/main/java/org/torproject/android/service/TorService.java b/orbotservice/src/main/java/org/torproject/android/service/TorService.java index 597e59e2..36c1b229 100644 --- a/orbotservice/src/main/java/org/torproject/android/service/TorService.java +++ b/orbotservice/src/main/java/org/torproject/android/service/TorService.java @@ -428,6 +428,14 @@ public class TorService extends Service implements TorServiceConstants, OrbotCon @Override public void onDestroy() { + try { + unregisterReceiver(mNetworkStateReceiver); + } + catch (IllegalArgumentException iae) + { + //not registered yet + } + stopTor(); /** @@ -476,13 +484,7 @@ public class TorService extends Service implements TorServiceConstants, OrbotCon clearNotifications(); sendCallbackStatus(STATUS_OFF); - try { - unregisterReceiver(mNetworkStateReceiver); - } - catch (IllegalArgumentException iae) - { - //not registered yet - } + } private void killAllDaemons() throws Exception {