dan
/
jekyll
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix rubocop errors & add one more test for slugify 'ascii' mode (#4680)

This commit is contained in:
Parker Moore 2016-09-07 17:50:14 -07:00
parent 9164973a6c
commit c1e6f1fb94
No known key found for this signature in database
GPG Key ID: 193CDEBA72063C58
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.rubocop.yml
View File

@ -23,7 +23,7 @@ Metrics/ClassLength:
- !ruby/regexp /test\/.*.rb$/ - !ruby/regexp /test\/.*.rb$/
Max: 300 Max: 300
Metrics/CyclomaticComplexity: Metrics/CyclomaticComplexity:
Max: 8 Max: 9
Metrics/LineLength: Metrics/LineLength:
Exclude: Exclude:
- !ruby/regexp /features\/.*.rb/ - !ruby/regexp /features\/.*.rb/

2
lib/jekyll/utils.rb
View File

@ -200,7 +200,7 @@ module Jekyll
# "._~!$&'()+,;=@" is human readable (not URI-escaped) in URL # "._~!$&'()+,;=@" is human readable (not URI-escaped) in URL
# and is allowed in both extN and NTFS. # and is allowed in both extN and NTFS.
SLUGIFY_PRETTY_REGEXP SLUGIFY_PRETTY_REGEXP
when 'ascii' when "ascii"
# For web servers not being able to handle Unicode, the safe # For web servers not being able to handle Unicode, the safe
# method is to ditch anything else but latin letters and numeric # method is to ditch anything else but latin letters and numeric
# digits. # digits.

5
test/test_utils.rb
View File

@ -199,7 +199,10 @@ class TestUtils < JekyllUnitTest
end end
should "replace everything else but ASCII characters" do should "replace everything else but ASCII characters" do
assert_equal "the-config-yml-file", Utils.slugify("The _config.yml file?", mode: "ascii") assert_equal "the-config-yml-file",
Utils.slugify("The _config.yml file?", :mode => "ascii")
assert_equal "f-rtive-glance",
Utils.slugify("fürtive glance!!!!", :mode => "ascii")
end end
should "only replace whitespace if mode is raw" do should "only replace whitespace if mode is raw" do