From b8f17b9034200a76bdbeb60ee5f4091e0acc8130 Mon Sep 17 00:00:00 2001 From: Parker Moore Date: Sun, 7 Aug 2016 12:15:58 -0700 Subject: [PATCH] Exclude node_modules by default If no 'exclude' directive is specified, exclude node_modules by default. https://twitter.com/mxstbr/status/761856359579185153 --- lib/jekyll/configuration.rb | 2 +- site/_docs/configuration.md | 2 +- test/test_configuration.rb | 6 ++++++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/jekyll/configuration.rb b/lib/jekyll/configuration.rb index 0f0fbd8d..196cf587 100644 --- a/lib/jekyll/configuration.rb +++ b/lib/jekyll/configuration.rb @@ -17,7 +17,7 @@ module Jekyll # Handling Reading "safe" => false, "include" => [".htaccess"], - "exclude" => ["vendor"], + "exclude" => %w(node_modules vendor), "keep_files" => [".git", ".svn"], "encoding" => "utf-8", "markdown_ext" => "markdown,mkdown,mkdn,mkd,md", diff --git a/site/_docs/configuration.md b/site/_docs/configuration.md index 4771a438..a244e1ab 100644 --- a/site/_docs/configuration.md +++ b/site/_docs/configuration.md @@ -594,7 +594,7 @@ collections: # Handling Reading safe: false include: [".htaccess"] -exclude: ["vendor"] +exclude: ["node_modules", "vendor"] keep_files: [".git", ".svn"] encoding: "utf-8" markdown_ext: "markdown,mkdown,mkdn,mkd,md" diff --git a/test/test_configuration.rb b/test/test_configuration.rb index 75daffa5..b0b34cce 100644 --- a/test/test_configuration.rb +++ b/test/test_configuration.rb @@ -48,6 +48,12 @@ class TestConfiguration < JekyllUnitTest end end + context "the defaults" do + should "exclude node_modules" do + assert_includes Configuration.from({})["exclude"], "node_modules" + end + end + context "#add_default_collections" do should "no-op if collections is nil" do result = Configuration[{ "collections" => nil }].add_default_collections