From 22cc59905b2100d9f3358abbeeb45f54b44a2511 Mon Sep 17 00:00:00 2001 From: Parker Moore Date: Fri, 18 Aug 2017 11:38:32 -0400 Subject: [PATCH 1/3] Add CODEOWNERS file to help automate reviews. Documentation from GitHub: https://help.github.com/articles/about-codeowners/ jekyllbot does too much already -- I'd like to see GitHub help us keep organized. This is also an exercise in logically splitting up the codebase. The build team is pretty overloaded it looks like -- can we split anything out? --- CODEOWNERS | 87 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 87 insertions(+) create mode 100644 CODEOWNERS diff --git a/CODEOWNERS b/CODEOWNERS new file mode 100644 index 00000000..d3d22145 --- /dev/null +++ b/CODEOWNERS @@ -0,0 +1,87 @@ +# The Jekyll project has 6 affinity teams, shown here: https://teams.jekyllrb.com/ +# They are as follows: +# +# 1. @jekyll/build +# 2. @jekyll/documentation +# 3. @jekyll/ecosystem +# 4. @jekyll/performance +# 5. @jekyll/stability +# 6. @jekyll/windows +# +# Each of these teams has a mission. Wherever possible, GitHub should +# automatically require review from these teams on the pieces of the +# repository they maintain. + +# @jekyll/documentation +/docs/ @jekyll/documentation + +# @jekyll/build +/exe/ @jekyll/build +/lib/jekyll.rb @jekyll/build +/lib/jekyll/cleaner.rb @jekyll/build +/lib/jekyll/collection.rb @jekyll/build +/lib/jekyll/command.rb @jekyll/build +/lib/jekyll/commands/ @jekyll/build +/lib/jekyll/converter.rb @jekyll/build +/lib/jekyll/converters/ @jekyll/build +/lib/jekyll/convertible.rb @jekyll/build +/lib/jekyll/document.rb @jekyll/build +/lib/jekyll/drops/ @jekyll/build +/lib/jekyll/entry_filter.rb @jekyll/build +/lib/jekyll/errors.rb @jekyll/build +/lib/jekyll/excerpt.rb @jekyll/build +/lib/jekyll/filters/ @jekyll/build +/lib/jekyll/filters.rb @jekyll/build +/lib/jekyll/layout.rb @jekyll/build +/lib/jekyll/liquid_extensions.rb @jekyll/build +/lib/jekyll/liquid_renderer/ @jekyll/build +/lib/jekyll/liquid_renderer.rb @jekyll/build +/lib/jekyll/log_adapter.rb @jekyll/build +/lib/jekyll/mime.types @jekyll/build +/lib/jekyll/page.rb @jekyll/build +/lib/jekyll/publisher.rb @jekyll/build +/lib/jekyll/reader.rb @jekyll/build +/lib/jekyll/readers/ @jekyll/build +/lib/jekyll/regenerator.rb @jekyll/build +/lib/jekyll/related_posts.rb @jekyll/build +/lib/jekyll/renderer.rb @jekyll/build +/lib/jekyll/site.rb @jekyll/build +/lib/jekyll/static_file.rb @jekyll/build +/lib/jekyll/stevenson.rb @jekyll/build +/lib/jekyll/tags/ @jekyll/build +/lib/jekyll/url.rb @jekyll/build +/lib/jekyll/utils/ @jekyll/build +/lib/jekyll/utils.rb @jekyll/build + +# @jekyll/ecosystem +/lib/jekyll/external.rb @jekyll/ecosystem +/lib/jekyll/generator.rb @jekyll/ecosystem +/lib/jekyll/hooks.rb @jekyll/ecosystem +/lib/jekyll/plugin.rb @jekyll/ecosystem +/lib/jekyll/plugin_manager.rb @jekyll/ecosystem +/lib/jekyll/theme.rb @jekyll/ecosystem +/lib/jekyll/theme_builder.rb @jekyll/ecosystem + +# @jekyll/stability +Gemfile @jekyll/stability +*.gemspec @jekyll/stability +.travis.yml @jekyll/stability +appveyor.yml @jekyll/stability +/lib/jekyll/configuration.rb @jekyll/stability +/lib/jekyll/deprecator.rb @jekyll/stability +/lib/jekyll/frontmatter_defaults.rb @jekyll/stability +/lib/site_template @jekyll/stability +/lib/theme_template @jekyll/stability +/features/ @jekyll/stability +/test/ @jekyll/stability + +# Special cases +.github/ @jekyll/affinity-team-captains +CODEOWNERS @jekyll/affinity-team-captains +CONDUCT.markdown @jekyll/affinity-team-captains +History.markdown @jekyll/affinity-team-captains +LICENSE @jekyll/affinity-team-captains # This file should never change. +README.markdown @jekyll/affinity-team-captains +/lib/jekyll/version.rb @jekyll/affinity-team-captains +/rake/ @jekyll/affinity-team-captains +/script/ @jekyll/affinity-team-captains From f232e1039af7a5d19ee7d15db043fd64f88eef4d Mon Sep 17 00:00:00 2001 From: Frank Taillandier Date: Fri, 18 Aug 2017 18:18:34 +0200 Subject: [PATCH 2/3] move CODEOWNERS to .github --- CODEOWNERS => .github/CODEOWNERS | 1 - 1 file changed, 1 deletion(-) rename CODEOWNERS => .github/CODEOWNERS (98%) diff --git a/CODEOWNERS b/.github/CODEOWNERS similarity index 98% rename from CODEOWNERS rename to .github/CODEOWNERS index d3d22145..67a51c50 100644 --- a/CODEOWNERS +++ b/.github/CODEOWNERS @@ -77,7 +77,6 @@ appveyor.yml @jekyll/stability # Special cases .github/ @jekyll/affinity-team-captains -CODEOWNERS @jekyll/affinity-team-captains CONDUCT.markdown @jekyll/affinity-team-captains History.markdown @jekyll/affinity-team-captains LICENSE @jekyll/affinity-team-captains # This file should never change. From f2860047b7e012e20f6dbce3ae43b0d9c4acf9b6 Mon Sep 17 00:00:00 2001 From: Frank Taillandier Date: Fri, 18 Aug 2017 18:20:24 +0200 Subject: [PATCH 3/3] /cc a team is now handled by CODEOWNERS --- .github/ISSUE_TEMPLATE.md | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index b1d43598..fdba8615 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -10,9 +10,6 @@ a generic usage question, please consider asking your question at https://talk.jekyllrb.com where non-bug questions go. - Please make sure to mention an affinity team whose responsibilities - most closely align with your issue. - Thanks! --> @@ -79,5 +76,3 @@ The minimum should be personal information. Though we normally don't log anything like that so there should be no need to alter it. --> - -/cc include any Jekyll affinity teams here (see https://teams.jekyllrb.com/ for more info)