From aaf0ba15ccbf9e2ded565b4115af9dd22b24ff8a Mon Sep 17 00:00:00 2001 From: Parker Moore Date: Sat, 17 Jan 2015 16:25:33 -0800 Subject: [PATCH] Use frozen regular expressions for Utils#slugify --- lib/jekyll/utils.rb | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/lib/jekyll/utils.rb b/lib/jekyll/utils.rb index ba0303a4..bba8b148 100644 --- a/lib/jekyll/utils.rb +++ b/lib/jekyll/utils.rb @@ -2,6 +2,12 @@ module Jekyll module Utils extend self + # Constants for use in #slugify + SLUGIFY_MODES = %w{raw default pretty} + SLUGIFY_RAW_REGEXP = Regexp.new('\\s+').freeze + SLUGIFY_DEFAULT_REGEXP = Regexp.new('[^[:alnum:]]+').freeze + SLUGIFY_PRETTY_REGEXP = Regexp.new("[^[:alnum:]._~!$&'()+,;=@]+").freeze + # Merges a master hash with another hash, recursively. # # master_hash - the "parent" hash whose values will be overridden @@ -129,19 +135,18 @@ module Jekyll def slugify(string, mode=nil) mode ||= 'default' return nil if string.nil? + return string.downcase unless SLUGIFY_MODES.include?(mode) # Replace each character sequence with a hyphen re = case mode when 'raw' - Regexp.new('\\s+') + SLUGIFY_RAW_REGEXP when 'default' - Regexp.new('[^[:alnum:]]+') + SLUGIFY_DEFAULT_REGEXP when 'pretty' # "._~!$&'()+,;=@" is human readable (not URI-escaped) in URL # and is allowed in both extN and NTFS. - Regexp.new("[^a-zA-Z0-9._~!$&'()+,;=@]+") - else - return string.downcase + SLUGIFY_PRETTY_REGEXP end string.