dan
/
jekyll
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix deprecation message for missing doc method (#8960) 

Merge pull request 8960
This commit is contained in:
Ashwin Maroli 2022-02-10 08:59:01 +05:30 committed by GitHub
parent d46bef774a
commit 88044a2ece
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 34 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
features/post_data.feature
View File

@ -382,3 +382,35 @@ Scenario: Use page.render_with_liquid variable
And the _site directory should exist
And I should see "next post: Some like it hot" in "_site/2009/03/27/star-wars.html"
And I should see "Previous post: Some like it hot" in "_site/2009/05/27/terminator.html"
Scenario: Deprecate calling data keys directly via Ruby
Given I have a _posts directory
And I have a _plugins directory
And I have the following post:
| title | date | content |
| My post | 2016-01-21 | Luke, I am your father. |
And I have a "_plugins/foo.rb" file with content:
"""
Jekyll::Hooks.register :documents, :pre_render do |doc|
doc.title
end
"""
And I have a "_plugins/bar.rb" file with content:
"""
module FooBar
def self.dummy?(doc)
doc.title == "Dummy Document"
end
end
Jekyll::Hooks.register :documents, :post_render do |doc|
FooBar.dummy?(doc)
end
"""
When I run jekyll build
Then I should get a zero exit status
And the _site directory should exist
And I should see "Deprecation: Document#title" in the build output
And I should see "_plugins/foo.rb:2" in the build output
And I should see "_plugins/bar.rb:3" in the build output
But I should not see "lib/jekyll/document.rb" in the build output

5
lib/jekyll/document.rb
View File

@ -406,9 +406,8 @@ module Jekyll
# Override of method_missing to check in @data for the key.
def method_missing(method, *args, &blck)
if data.key?(method.to_s)
Jekyll::Deprecator.deprecation_message "Document##{method} is now a key "\
"in the #data hash."
Jekyll::Deprecator.deprecation_message "Called by #{caller(0..0)}."
Jekyll::Deprecator.deprecation_message "Document##{method} is now a key in the #data hash."
Jekyll.logger.warn "", "Called by #{caller(1..1)[0]}."
data[method.to_s]
else
super