Configure Performance cops (#8369)

Merge pull request 8369
This commit is contained in:
Ashwin Maroli 2020-09-04 15:38:14 +05:30 committed by GitHub
parent ae6911d38a
commit 822bb57d41
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 9 deletions

View File

@ -114,6 +114,27 @@ Naming/MemoizedInstanceVariableName:
- lib/jekyll/drops/unified_payload_drop.rb
- lib/jekyll/page_without_a_file.rb
Performance/AncestorsInclude:
Enabled: false
Performance/BigDecimalWithNumericArgument:
Enabled: true
Performance/RedundantSortBlock:
Enabled: true
Performance/RedundantStringChars:
Enabled: true
Performance/ReverseFirst:
Enabled: true
Performance/SortReverse:
Enabled: false
Performance/Squeeze:
Enabled: true
Performance/StringInclude:
Enabled: true
Exclude:
- lib/jekyll/utils/platforms.rb
Performance/Sum:
Enabled: true
Security/MarshalLoad:
Exclude:
- !ruby/regexp /test\/.*.rb$/

View File

@ -790,11 +790,9 @@ class TestFilters < JekyllUnitTest
should "successfully group array of Jekyll::Page's" do
@filter.site.process
grouping = @filter.group_by(@filter.site.pages, "layout")
names = ["default", "nil", ""]
grouping.each do |g|
assert(
["default", "nil", ""].include?(g["name"]),
"#{g["name"]} isn't a valid grouping."
)
assert names.include?(g["name"]), "#{g["name"]} isn't a valid grouping."
case g["name"]
when "default"
assert(
@ -1284,11 +1282,9 @@ class TestFilters < JekyllUnitTest
should "successfully group array of Jekyll::Page's" do
@filter.site.process
groups = @filter.group_by_exp(@filter.site.pages, "page", "page.layout | upcase")
names = ["DEFAULT", "NIL", ""]
groups.each do |g|
assert(
["DEFAULT", "NIL", ""].include?(g["name"]),
"#{g["name"]} isn't a valid grouping."
)
assert names.include?(g["name"]), "#{g["name"]} isn't a valid grouping."
case g["name"]
when "DEFAULT"
assert(

View File

@ -97,7 +97,7 @@ class TestFrontMatterDefaults < JekyllUnitTest
)
@site.process
@affected = @site.posts.docs.find { |page| page.relative_path =~ %r!win/! }
@affected = @site.posts.docs.find { |page| page.relative_path.include?("win") }
@not_affected = @site.pages.find { |page| page.relative_path == "about.html" }
end