Shoulda-izing the pager test and correcting some formatting issues

features/pagination.feature

@@ -9,14 +9,9 @@ Feature: Site pagination
     And I have an "index.html" file that contains "Basic Site"
     And I have a _posts directory
     And I have the following post:
-      | title    | date      | layout  | content                               |
+      | title     | date      | layout  | content                                |
-      | Wargames | 3/27/2009 | default | The only winning move is not to play. |
+      | Wargames  | 3/27/2009 | default | The only winning move is not to play.  |
       | Wargames2 | 4/27/2009 | default | The only winning move is not to play2. |
     When I run jekyll
     Then the _site/page2 directory should exist
     And the _site/page2/index.html file should exist
-  
-  
-  
-
-  

lib/jekyll/pager.rb

@@ -18,7 +18,7 @@ module Jekyll
       @total_pages = num_pages || Pager.calculate_pages(all_posts, @per_page)
       
       if @page > @total_pages
-        raise RuntimeError, "page number can't be grater than total pages: #{@page} > #{@total_pages}"
+        raise RuntimeError, "page number can't be greater than total pages: #{@page} > #{@total_pages}"
       end
       
       init = (@page - 1) * @per_page

test/test_pager.rb

@@ -1,47 +1,47 @@
 require File.dirname(__FILE__) + '/helper'
 
 class TestPager < Test::Unit::TestCase
+  context "pagination enabled" do
+    setup do
+      stub(Jekyll).configuration do
+        Jekyll::DEFAULTS.merge({
+          'source'      => source_dir, 
+          'destination' => dest_dir,
+          'paginate'    => 2
+        })
+      end
 
-  def setup
+      @config = Jekyll.configuration
-    stub(Jekyll).configuration do
+      @site = Site.new(@config)
-      Jekyll::DEFAULTS.merge({'source' => source_dir, 'destination' => dest_dir,
+      @posts = @site.read_posts('')
-        'paginate' => 2})
     end
 
-    @config = Jekyll.configuration
+    should "calculate number of pages" do
-    @site = Site.new(@config)
+      assert_equal(2, Pager.calculate_pages(@posts, @config['paginate']))
-    @posts = @site.read_posts('')
+    end
-  end
 
-  def teardown
+    should "create first pager" do
-    @config = Jekyll.configuration('paginate' => nil)
+      pager = Pager.new(@config, 1, @posts)
-  end
+      assert_equal(@config['paginate'].to_i, pager.posts.size)
+      assert_equal(2, pager.total_pages)
+      assert_nil(pager.previous_page)
+      assert_equal(2, pager.next_page)
+    end
   
-  def test_calculate_pages
+    should "create second pager" do
-    assert_equal(2, Pager.calculate_pages(@posts, @config['paginate']))
+      pager = Pager.new(@config, 2, @posts)
-  end
+      assert_equal(@posts.size - @config['paginate'].to_i, pager.posts.size)
+      assert_equal(2, pager.total_pages)
+      assert_equal(1, pager.previous_page)
+      assert_nil(pager.next_page)
+    end
     
-  def test_create_first_pager
+    should "not create third pager" do
-    pager = Pager.new(@config, 1, @posts)
+      assert_raise(RuntimeError) { Pager.new(@config, 3, @posts) }
-    assert_equal(@config['paginate'].to_i, pager.posts.size)
+    end
-    assert_equal(2, pager.total_pages)
-    assert_nil(pager.previous_page)
-    assert_equal(2, pager.next_page)
-  end
     
-  def test_create_second_pager
+    should "report that pagination is enabled" do
-    pager = Pager.new(@config, 2, @posts)
+      assert Pager.pagination_enabled?(@config, 'index.html')
-    assert_equal(@posts.size - @config['paginate'].to_i, pager.posts.size)
+    end
-    assert_equal(2, pager.total_pages)
-    assert_equal(1, pager.previous_page)
-    assert_nil(pager.next_page)
-  end
-  
-  def test_create_third_pager
-    assert_raise(RuntimeError) { Pager.new(@config, 3, @posts) }
-  end
-  
-  def test_pagination_enabled_with_command_option
-    assert_equal(true, Pager.pagination_enabled?(@config, 'index.html'))
   end
 end