Incorporate code review feedback
This commit is contained in:
		
							parent
							
								
									a0da18e4f8
								
							
						
					
					
						commit
						6055f112fb
					
				|  | @ -66,9 +66,7 @@ module Jekyll | ||||||
| 
 | 
 | ||||||
|         def urls_only_differ_by_case(site) |         def urls_only_differ_by_case(site) | ||||||
|           urls_only_differ_by_case = false |           urls_only_differ_by_case = false | ||||||
|           urls = {} |           urls = case_insensitive_urls(site.pages + site.posts, site.dest) | ||||||
|           urls = collect_urls_case_insensitive(urls, site.pages, site.dest) |  | ||||||
|           urls = collect_urls_case_insensitive(urls, site.posts, site.dest) |  | ||||||
|           urls.each do |case_insensitive_url, real_urls| |           urls.each do |case_insensitive_url, real_urls| | ||||||
|             if real_urls.uniq.size > 1 |             if real_urls.uniq.size > 1 | ||||||
|               urls_only_differ_by_case = true |               urls_only_differ_by_case = true | ||||||
|  | @ -94,13 +92,12 @@ module Jekyll | ||||||
|           urls |           urls | ||||||
|         end |         end | ||||||
| 
 | 
 | ||||||
|         def collect_urls_case_insensitive(urls, things, destination) |         def case_insensitive_urls(things, destination) | ||||||
|           things.inject(urls) do |memo, thing| |           things.inject(Hash.new) do |memo, thing| | ||||||
|             dest = thing.destination(destination) |             dest = thing.destination(destination) | ||||||
|             (memo[dest.downcase] ||= []) << dest |             (memo[dest.downcase] ||= []) << dest | ||||||
|             memo |             memo | ||||||
|           end |           end | ||||||
|           urls |  | ||||||
|         end |         end | ||||||
|       end |       end | ||||||
| 
 | 
 | ||||||
|  |  | ||||||
		Loading…
	
		Reference in New Issue