From 3f0c77cfd5bde557ce0e89b6684d50a0ddd37dba Mon Sep 17 00:00:00 2001
From: Parker Moore <parkrmoore@gmail.com>
Date: Thu, 10 Aug 2017 16:27:14 -0400
Subject: [PATCH] Add a quick test for DataReader (#6284)

Merge pull request 6284
---
 lib/jekyll/readers/data_reader.rb |  4 ++--
 test/test_data_reader.rb          | 17 +++++++++++++++++
 2 files changed, 19 insertions(+), 2 deletions(-)
 create mode 100644 test/test_data_reader.rb

diff --git a/lib/jekyll/readers/data_reader.rb b/lib/jekyll/readers/data_reader.rb
index e2671f2d..445d5488 100644
--- a/lib/jekyll/readers/data_reader.rb
+++ b/lib/jekyll/readers/data_reader.rb
@@ -70,8 +70,8 @@ module Jekyll
     end
 
     def sanitize_filename(name)
-      name.gsub!(%r![^\w\s-]+|(?<=^|\b\s)\s+(?=$|\s?\b)!, "".freeze)
-      name.gsub(%r!\s+!, "_")
+      name.gsub(%r![^\w\s-]+|(?<=^|\b\s)\s+(?=$|\s?\b)!, "")
+        .gsub(%r!\s+!, "_")
     end
   end
 end
diff --git a/test/test_data_reader.rb b/test/test_data_reader.rb
new file mode 100644
index 00000000..038ec679
--- /dev/null
+++ b/test/test_data_reader.rb
@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require "helper"
+
+class TestDataReader < JekyllUnitTest
+  context "#sanitize_filename" do
+    setup do
+      @reader = DataReader.new(fixture_site)
+    end
+
+    should "remove evil characters" do
+      assert_equal "helpwhathaveIdone", @reader.sanitize_filename(
+        "help/what^&$^#*(!^%*!#haveId&&&&&&&&&one"
+      )
+    end
+  end
+end