Remove rescue for to_i

This commit is contained in:
David Zhang 2016-07-14 14:06:25 +08:00
parent b44457a80b
commit 3435b5ddac
2 changed files with 8 additions and 9 deletions

View File

@ -4,7 +4,6 @@ require "date"
require "liquid"
module Jekyll
# rubocop:disable Metrics/ModuleLength
module Filters
# Convert a Markdown string into HTML output.
#
@ -269,12 +268,7 @@ module Jekyll
def to_integer(input)
return 1 if input == true
return 0 if input == false
begin
input.to_i
rescue
raise ArgumentError,
"Object '#{input.inspect}' could not be converted into an integer."
end
input.to_i
end
# Sort an array of objects

View File

@ -645,8 +645,13 @@ class TestFilters < JekyllUnitTest
context "to_integer filter" do
should "raise Exception when input is not integer or string" do
err_msg = "Object '[1, 2]' could not be converted into an integer."
err = assert_raises ArgumentError do
err_msg = <<-EOS.strip!
undefined method `to_i' for [1, 2]:Array
Did you mean? to_s
to_a
to_h
EOS
err = assert_raises NoMethodError do
@filter.to_integer([1, 2])
end
assert_equal err_msg, err.message