Added corrections as suggested by @parkr.

- Replaced occurrences of #array += with concat
   operations.(performance)
 - Corrected alignment.
 - Removed rebase artifact.

Signed-off-by: Martin Rogalla <martin@martinrogalla.com>
This commit is contained in:
Martin Rogalla 2015-03-19 14:56:00 +01:00
parent b178358cf9
commit 324748a5a6
5 changed files with 13 additions and 14 deletions

View File

@ -51,8 +51,8 @@ module Jekyll
#
# Returns nothing.
def retrieve_posts(dir)
site.posts += PostReader.new(site).read(dir)
site.posts += DraftReader.new(site).read(dir) if site.show_drafts
site.posts.concat(PostReader.new(site).read(dir))
site.posts.concat(DraftReader.new(site).read(dir)) if site.show_drafts
site.posts.sort!
end
@ -72,7 +72,7 @@ module Jekyll
#
# Returns nothing.
def retrieve_pages(dir, dot_pages)
site.pages += PageReader.new(site, dir).read(dot_pages)
site.pages.concat(PageReader.new(site, dir).read(dot_pages))
site.pages.sort_by!(&:name)
end
@ -81,7 +81,7 @@ module Jekyll
#
# Returns nothing.
def retrieve_static_files(dir, dot_static_files)
site.static_files += StaticFileReader.new(site, dir).read(dot_static_files)
site.static_files.concat(StaticFileReader.new(site, dir).read(dot_static_files))
site.static_files.sort_by!(&:relative_path)
end

View File

@ -191,7 +191,6 @@ permalink: "/docs/history/"
- Allow Travis to 'parallelize' our tests ([#2859]({{ site.repository }}/issues/2859))
- Fix test for Liquid rendering in Sass ([#2856]({{ site.repository }}/issues/2856))
- Fixing "vertycal" typo in site template's `_base.scss` ([#2889]({{ site.repository }}/issues/2889))
- Convert remaining textile test documents to markdown ([#3528]({{ site.repository }}/issues/3528))
### Site Enhancements
{: #site-enhancements-v2-4-0}

View File

@ -189,7 +189,7 @@ class TestSite < JekyllUnitTest
end
should "read posts" do
@site.posts += PostReader.new(@site).read('')
@site.posts.concat(PostReader.new(@site).read(''))
posts = Dir[source_dir('_posts', '**', '*')]
posts.delete_if { |post| File.directory?(post) && !Post.valid?(post) }
assert_equal posts.size - @num_invalid_posts, @site.posts.size

View File

@ -13,7 +13,7 @@ class TestTags < JekyllUnitTest
site = Site.new(Jekyll.configuration)
if override['read_posts']
site.posts += PostReader.new(site).read('')
site.posts.concat(PostReader.new(site).read(''))
end
info = { :filters => [Jekyll::Filters], :registers => { :site => site } }