From 57d07469d362c1fde5f6d9ce44c4507aa9dfe814 Mon Sep 17 00:00:00 2001
From: Parker Moore <parkrmoore@gmail.com>
Date: Mon, 17 Feb 2014 22:59:51 -0500
Subject: [PATCH] Sanitize paths uniformly, in a Windows-friendly way.

Fixes kinda a #1948 thing.
Related to #1946.
---
 lib/jekyll.rb               | 20 ++++++++++++++++++++
 lib/jekyll/layout_reader.rb |  6 ++----
 lib/jekyll/page.rb          |  4 ++--
 lib/jekyll/post.rb          |  2 +-
 4 files changed, 25 insertions(+), 7 deletions(-)

diff --git a/lib/jekyll.rb b/lib/jekyll.rb
index c4cbc8a0..d89d41ec 100644
--- a/lib/jekyll.rb
+++ b/lib/jekyll.rb
@@ -102,4 +102,24 @@ module Jekyll
   def self.logger
     @logger ||= Stevenson.new
   end
+
+  # Public: File system root
+  #
+  # Returns the root of the filesystem as a Pathname
+  def self.fs_root
+    @fs_root ||= traverse_up(Pathname.new(Dir.pwd))
+  end
+
+  def self.sanitized_path(base_directory, questionable_path)
+    clean_path = File.expand_path(questionable_path, fs_root)
+    clean_path.sub(/\A[\w]:\\\\/, '')
+    File.join(base_directory, clean_path)
+  end
+
+  private
+
+  def self.traverse_up(pathname)
+    return pathname if pathname.parent.eql?(pathname)
+    traverse_up(pathname.parent)
+  end
 end
diff --git a/lib/jekyll/layout_reader.rb b/lib/jekyll/layout_reader.rb
index 66854339..3aebf760 100644
--- a/lib/jekyll/layout_reader.rb
+++ b/lib/jekyll/layout_reader.rb
@@ -38,13 +38,11 @@ module Jekyll
     end
 
     def layout_directory_inside_source
-      # TODO: Fix for Windows
-      File.join(site.source, File.expand_path(site.config['layouts'], "/"))
+      Jekyll.sanitized_path(site.source, site.config['layouts'])
     end
 
     def layout_directory_in_cwd
-      # TODO: Fix on Windows
-      dir = File.join(Dir.pwd, File.expand_path(site.config['layouts'], '/'))
+      dir = Jekyll.sanitized_path(Dir.pwd, site.config['layouts'])
       if File.directory?(dir)
         dir
       else
diff --git a/lib/jekyll/page.rb b/lib/jekyll/page.rb
index f6f9fffc..6900e533 100644
--- a/lib/jekyll/page.rb
+++ b/lib/jekyll/page.rb
@@ -135,7 +135,7 @@ module Jekyll
     #
     # Returns the destination file path String.
     def destination(dest)
-      path = File.join(dest, File.expand_path(url, "/"))
+      path = Jekyll.sanitized_path(dest, url)
       path = File.join(path, "index.html") if url =~ /\/$/
       path
     end
@@ -156,7 +156,7 @@ module Jekyll
     end
 
     def uses_relative_permalinks
-      permalink && @dir != "" && site.config['relative_permalinks']
+      permalink && !@dir.empty? && site.config['relative_permalinks']
     end
   end
 end
diff --git a/lib/jekyll/post.rb b/lib/jekyll/post.rb
index 7cf7969d..58d1fc5f 100644
--- a/lib/jekyll/post.rb
+++ b/lib/jekyll/post.rb
@@ -260,7 +260,7 @@ module Jekyll
     # Returns destination file path String.
     def destination(dest)
       # The url needs to be unescaped in order to preserve the correct filename
-      path = File.join(dest, File.expand_path(CGI.unescape(url), "/"))
+      path = Jekyll.sanitized_path(dest, CGI.unescape(url))
       path = File.join(path, "index.html") if path[/\.html$/].nil?
       path
     end