Make custom cop inherit `RuboCop::Cop::Base` (#9597)
Merge pull request 9597
This commit is contained in:
parent
c52149824d
commit
28e10da266
|
@ -26,8 +26,11 @@ module RuboCop
|
|||
# @alpha.omega
|
||||
# )
|
||||
#
|
||||
class AssertEqualLiteralActual < Cop
|
||||
MSG = "Provide the 'expected value' as the first argument to `assert_equal`.".freeze
|
||||
class AssertEqualLiteralActual < Base
|
||||
extend AutoCorrector
|
||||
|
||||
MSG = "Provide the 'expected value' as the first argument to `assert_equal`."
|
||||
RESTRICT_ON_SEND = %i[assert_equal].freeze
|
||||
|
||||
SIMPLE_LITERALS = %i(
|
||||
true
|
||||
|
@ -61,12 +64,10 @@ module RuboCop
|
|||
|
||||
def on_send(node)
|
||||
return unless literal_actual?(node) || literal_actual_with_msg?(node)
|
||||
add_offense(node, location: :expression)
|
||||
end
|
||||
|
||||
def autocorrect(node)
|
||||
lambda do |corrector|
|
||||
corrector.replace(node.loc.expression, replacement(node))
|
||||
range = node.loc.expression
|
||||
add_offense(range) do |corrector|
|
||||
corrector.replace(range, replacement(node))
|
||||
end
|
||||
end
|
||||
|
||||
|
|
|
@ -1,20 +1,19 @@
|
|||
# frozen_string_literal: true
|
||||
|
||||
require "rubocop"
|
||||
|
||||
module RuboCop
|
||||
module Cop
|
||||
module Jekyll
|
||||
class NoPAllowed < Cop
|
||||
MSG = "Avoid using `p` to print things. Use `Jekyll.logger` instead.".freeze
|
||||
class NoPAllowed < Base
|
||||
MSG = "Avoid using `p` to print things. Use `Jekyll.logger` instead."
|
||||
RESTRICT_ON_SEND = %i[p].freeze
|
||||
|
||||
def_node_search :p_called?, <<-PATTERN
|
||||
(send _ :p _)
|
||||
(send _ :p _)
|
||||
PATTERN
|
||||
|
||||
def on_send(node)
|
||||
if p_called?(node)
|
||||
add_offense(node, :location => :selector)
|
||||
add_offense(node.loc.selector)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
|
@ -1,20 +1,19 @@
|
|||
# frozen_string_literal: true
|
||||
|
||||
require "rubocop"
|
||||
|
||||
module RuboCop
|
||||
module Cop
|
||||
module Jekyll
|
||||
class NoPutsAllowed < Cop
|
||||
MSG = "Avoid using `puts` to print things. Use `Jekyll.logger` instead.".freeze
|
||||
class NoPutsAllowed < Base
|
||||
MSG = "Avoid using `puts` to print things. Use `Jekyll.logger` instead."
|
||||
RESTRICT_ON_SEND = %i[puts].freeze
|
||||
|
||||
def_node_search :puts_called?, <<-PATTERN
|
||||
(send nil? :puts _)
|
||||
(send nil? :puts _)
|
||||
PATTERN
|
||||
|
||||
def on_send(node)
|
||||
if puts_called?(node)
|
||||
add_offense(node, :location => :selector)
|
||||
add_offense(node.loc.selector)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Reference in New Issue