From 1f298e0d9d3482492a43d0b37262342631c95894 Mon Sep 17 00:00:00 2001 From: Parker Moore Date: Sat, 26 Dec 2015 12:32:21 -0500 Subject: [PATCH] url: move setter outside of if statement Addresses @envygeeks's comment: https://github.com/jekyll/jekyll/commit/d070a77716f65fc9cbdef1aed91943959e9616e0#commitcomment-15164169 --- lib/jekyll/url.rb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/jekyll/url.rb b/lib/jekyll/url.rb index a001f44d..3f00cfd3 100644 --- a/lib/jekyll/url.rb +++ b/lib/jekyll/url.rb @@ -80,10 +80,11 @@ module Jekyll def generate_url_from_drop(template) template.gsub(/:([a-z_]+)/) do |match| - if replacement = @placeholders.public_send(match.sub(':', '')) - self.class.escape_path replacement - else + replacement = @placeholders.public_send(match.sub(':', '')) + if replacement.nil? ''.freeze + else + self.class.escape_path(replacement) end end.gsub(/\/\//, '/') end